Refactor: Enable TypeScript strict null checks #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebmer
force-pushed
the
refactor/ts-strict-null-checks
branch
from
16a1c3b to
9555292
Compare
helfer
approved these changes
Jan 23, 2017
| @@ -11,7 +11,7 @@ Expect active development and potentially significant breaking changes in the `0 | |||
| - Fix bug where there could be store inconsistencies for two dependent optimistic updates [PR #1144](https://github.com/apollostack/apollo-client/pull/1144) | |||
| - expose partial in ObservableQuery#currentResult [PR #1097](https://github.com/apollostack/apollo-client/pull/1097) | |||
| - Calculate `loading` from `networkStatus`. [PR #1202](https://github.com/apollostack/apollo-client/pull/1202) | |||
| - Fix typings error with `strictNullChecks` [PR #1188](https://github.com/apollostack/apollo-client/pull/1188) | |||
| - Fix typings error with `strictNullChecks` and enable TypeScript strict null checking in source code. [PR #1188](https://github.com/apollostack/apollo-client/pull/1188) and [PR #1221](https://github.com/apollostack/apollo-client/pull/1221) | |||
There was a problem hiding this comment.
What's the rationale for putting this under 0.8 instead of vNEXT?
There was a problem hiding this comment.
I didn’t realize there was a release and I missed the vNEXT when resolving the merge conflicts 😉
|
Also, we should merge this before we merged anything else, because otherwise we'll have a ton of conflicts. |
|
@helfer agreed. Not sure if it caught any bugs that would ever realistically happen (because if they would realistically happen we likely already fixed it). Of course, we will never know now once this gets merged 😉 For fun, here are some candidates for bug fixes:
|
|
Yeah, those don't look like super-likely candidates, but let's see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables TypeScript
strictNullChecksfor increased type safety guarantees. A longer term solution to #800