Mutation results

[stubailo]

See #317 for design, please give feedback.

• Summary in CHANGELOG: https://github.com/apollostack/apollo-client/blob/0c68047ad0d34f15cc73b37b04af6807ff6e9f77/CHANGELOG.md#vnext
• See some mutations in the tests: https://github.com/apollostack/apollo-client/blob/0c68047ad0d34f15cc73b37b04af6807ff6e9f77/test/mutationResults.ts

TODO:

• Make sure you don't have to manually type the dataId for store path
• Update CHANGELOG.md with your change
• Make sure all of the significant new logic is covered by tests
• Rebase your changes on master so that they can be merged easily
• Make sure all tests and linter rules pass

---

• Review with @Poincare
• Refactor mutation reducer arguments after talking to Abhi

---

Additional tests needed:

• generateMutationResultDataId in ARRAY_INSERT
• array reference equality after cleanArray, both on nested and non-nested arrays
• DELETE on nested array
• scope query with colliding fields: regular, inline fragment, and named fragment

[abhiaiyer91]

we should prefix with APOLLO_ to be consistent no?

[stubailo]

These aren't real actions - they end up in the applyResults section of the MUTATION_RESULT action, here: https://github.com/apollostack/apollo-client/pull/320/files#diff-162241b86351f640a8bb3127ed5fbd5bR92

This is because we want to process all of the mutation result stuff synchronously in one pass, rather than as multiple actions one after the other - it seems weird to me to fire many actions in one tick, when they represent one event (a mutation arriving from the server).

[Poincare]

Would it make sense to not call these actions at all? I was confused at first by this as well. It seems that these are more like "action applications" although I don't think that is a good name for them. I just think calling them "actions" makes it seem as though they are actual actions which will lead to a transition within the Redux store which can be a bit confusing.

[stubailo]

I think I'm going to call them "behaviors" after thinking about it.

[Poincare]

I made a couple of comments but looks good to me overall. Excited for this to get merged!

[stubailo]

A good day's worth of work, finally being merged! Feels good. And with good test coverage to boot. Now to write the docs...