Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump dep, don't work with Node.js ^21.0.0 fix #580 #612

Merged
merged 1 commit into from
May 21, 2024

Conversation

doitwithnotepad
Copy link
Contributor

ThunderHub does not work with nodejs ^21.0.0 due to echarts dependency which at the same time had an issue with its zrender dependency.

Solved on zrender ^5.5.0, bump deps on echarts ^5.5.0

Issue description on #580

Verified

This commit was signed with the committer’s verified signature.
@AdamuAbba
Copy link

hey @apotdevin I would love to help review a couple of PRs including this one to take some work off your hands and also give a second opinion. does this possibility work for you?

@apotdevin apotdevin enabled auto-merge (squash) May 21, 2024 17:35
@apotdevin apotdevin disabled auto-merge May 21, 2024 17:35
@apotdevin apotdevin merged commit 8569981 into apotdevin:master May 21, 2024
okjodom pushed a commit to bitsacco/thunderhub that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants