Skip to content

Commit

Permalink
Replace easy_install usage with the pip equivalents (#1836)
Browse files Browse the repository at this point in the history
easy_install (used with setup.py install) will install pre-releases
which is unexpected and undesirable behavior.

More information:

pypa/setuptools#855
  • Loading branch information
Steve Teahan authored Sep 14, 2021
1 parent 7166778 commit dcd5f29
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
9 changes: 5 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,16 +126,17 @@ python3 -m venv venv
source venv/bin/activate

# make sure you are running the latest setuptools
python3 -m pip install --upgrade pip setuptools
pip install --upgrade pip setuptools
```

Install the package:

```sh
python3 setup.py install
pip install .

# or alternatively use this for a devel environment
python3 setup.py develop
# or use this for development mode so rebuild/reinstall isn't necessary after
# each change that is made during development
pip install -e .

# optionally install all test/type dependencies - useful when writing tests,
# auto-completion in your IDE, etc.
Expand Down
4 changes: 3 additions & 1 deletion dockerfiles/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ COPY reconcile reconcile
COPY tools tools
COPY setup.py .

RUN python3 setup.py install
# setup.py install is not used because it will install pre-releases:
# https://github.com/pypa/setuptools/issues/855
RUN python3 -m pip install .

COPY dockerfiles/hack/run-integration.py /run-integration.py
CMD [ "/run-integration.py" ]

0 comments on commit dcd5f29

Please sign in to comment.