Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace easy_install usage with the pip equivalents #1836

Merged
merged 3 commits into from
Sep 14, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,16 +126,17 @@ python3 -m venv venv
source venv/bin/activate

# make sure you are running the latest setuptools
python3 -m pip install --upgrade pip setuptools
pip install --upgrade pip setuptools
```

Install the package:

```sh
python3 setup.py install
pip install .

# or alternatively use this for a devel environment
python3 setup.py develop
# or use this for development mode so rebuild/reinstall isn't necessary after
# each change that is made during development
pip install -e .

# optionally install all test/type dependencies - useful when writing tests,
# auto-completion in your IDE, etc.
Expand Down
4 changes: 3 additions & 1 deletion dockerfiles/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ COPY reconcile reconcile
COPY tools tools
COPY setup.py .

RUN python3 setup.py install
# setup.py install is not used because it will install pre-releases:
# https://github.com/pypa/setuptools/issues/855
RUN python3 -m pip install .

COPY dockerfiles/hack/run-integration.py /run-integration.py
CMD [ "/run-integration.py" ]