Replaced Godeps with glide #632
Conversation
|
Same as elsewhere - this imports a bunch of cruft - could you run glide-vc please? |
Did that now, thousands of changes lesser now. |
|
how about with the --no-tests flag? :-) |
|
|
|
@tboerger thanks! Just a few nitpicks from my side:
|
|
Except the documentation on |
|
@s-urbaniak rereview? |
| package: "github.com/appc/spec" | ||
| import: | ||
| - package: github.com/coreos/go-semver | ||
| version: 6fe83ccda8fb9b7549c9ab4ba47f47858bc950aa |
|
@tboerger added a few version pointers for the glide.yaml, where available. We bumped to k8s 1.3.0 in master, so you'll have to revendor and rebase. |
|
@s-urbaniak I think now it should be fine :) |
|
great, thanks, hopefully you won't kill me now if I ask you to reformat the commit messages to comply to https://github.com/appc/spec/blob/master/CONTRIBUTING.md#format-of-the-commit-message ;-) |
|
@s-urbaniak hopefully you are happy now? :) |
In preparation of the switch to glide instead of Godeps I have dropped the entire Godeps directory.
I have generated the glide configuration to properly replace Godeps with glide as a dependency manager.
|
@tboerger good stuff, I checked out the PR locally, and found one thing, in commit 29e4e7a you're pulling all vendored ~140MB dependencies, and in commit f824d7b you are pruning them down to ~1MB. I'd suggest to squash both commits (check in only pruned dependencies using Other than that lgtm, and thanks a lot for the patience ;-) |
I have added the vendored dependencies managed with glide, this works only for the Go vendoring experiment of course.
I have unified the build and test script, now it should be the same style as for all other appc projects.
To make updates of the dependencies easier I have added this script, now it's just a single command to update the deps and clean unused packages.
|
@s-urbaniak done :) |
|
@tboerger thanks a lot, lgtm! 👍 |
|
Outstanding. Thanks so much! |
The same as for the other appc repositories. I have entirely replaced Godeps with glide and while I have imported Godeps into glide it still updated some dependencies.