Skip to content
This repository has been archived by the owner on Aug 14, 2020. It is now read-only.

CRI: Move volume override from MountPoint to Mount #662

Merged
merged 1 commit into from
Oct 7, 2016

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Oct 7, 2016

No description provided.

Copy link
Contributor

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit, else LGTM

@@ -27,10 +27,9 @@ import (
// The Volume is optional. If missing, the pod-level Volume of the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no Volume field in this struct any more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this part should move to the other struct

Copy link
Contributor

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once green

@squeed squeed merged commit c204336 into appc:cri Oct 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants