Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support eslint 8 #90

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Conversation

ewanharris
Copy link
Contributor

This introduces support for eslint 8 and updates all dependencies that require updates to support
eslint 8

BREAKING CHANGE: Drops support for eslint 7
BREAKING CHANGE: Drops support for @typescript-eslint 4.x packages
BREAKING CHANGE: Drops support for eslint-plugin-mocha 9.x
BREAKING CHANGE: Updates to latest versions of built in eslint plugins

Although the eslint-plugin-node PR is still to be merged that isn't actually required to support eslint 8, I have verified this against titanium_mobile and vscode-appcelerator-titanium repos

@ewanharris ewanharris requested a review from cb1kenobi January 4, 2022 16:26
This introduces support for eslint 8 and updates all dependencies that require updates to support
eslint 8

BREAKING CHANGE: Drops support for eslint 7
BREAKING CHANGE: Drops support for @typescript-eslint 4.x packages
BREAKING CHANGE: Drops support for eslint-plugin-mocha 9.x
BREAKING CHANGE: Updates to latest versions of built in eslint plugins

Closes appcelerator#81
@pkclark
Copy link
Member

pkclark commented Jan 19, 2022

@cb1kenobi any ETA on the requested review?

Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! APPROVED

@cb1kenobi cb1kenobi merged commit 06978ed into appcelerator:master Jan 20, 2022
@ewanharris ewanharris deleted the feat/eslint-8 branch January 20, 2022 15:55
@pkclark
Copy link
Member

pkclark commented Jan 20, 2022

Thank you @cb1kenobi You're my hero! 🦸 Tag @lachezar-angelov a bump to 7.0.0 should resolve our peer dep issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants