Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for activities with multilingual chars #770

Conversation

tomaskatz96
Copy link

No description provided.

Copy link

linux-foundation-easycla bot commented Nov 5, 2024

CLA Not Signed

@mykola-mokhnach
Copy link
Contributor

@tomaskatz96 Please make sure your local git account email address is the same that has been used to sign CLA. You may use https://stackoverflow.com/questions/37805621/change-email-address-in-git for the reference. It would be enough to just perform one commit with the correct email to make the automatic CLA validation happy.

@tomaskatz96
Copy link
Author

@mykola-mokhnach committed with the right mail and still not authorized for some reason

@KazuCocoa
Copy link
Member

What about the steps below?

  1. git rebase your two commit in this PR to one
  2. git commit and run amend with author with your signed email address

https://stackoverflow.com/questions/3042437/how-can-i-change-the-commit-author-for-a-single-commit

Then, you may need to do a force push to the branch once

@tomaskatz96 tomaskatz96 force-pushed the add_multilingual_support_for_activities branch 2 times, most recently from 19265b9 to a537ce7 Compare November 10, 2024 08:21
@tomaskatz96 tomaskatz96 force-pushed the add_multilingual_support_for_activities branch from a537ce7 to ae7911f Compare November 10, 2024 08:24
@KazuCocoa
Copy link
Member

Hm, what email did you use for the sign to CLA? tomas.katz@mail.huji.ac.il...? (from the latest git log)
If so, could you re-create a PR with the latest branch again?

@tomaskatz96
Copy link
Author

@KazuCocoa Will try to open the PR again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants