Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make package argument of startUri optional #776

Merged

Conversation

fur0ut0
Copy link
Contributor

@fur0ut0 fur0ut0 commented Dec 9, 2024

startUri() requires pkg argument as app package name but app package can be omitted on executing am start.

It may show disambiguation popup in some cases (e.g. when there are multiple apps which handle the given URI and the default app is not configured.)

Copy link

linux-foundation-easycla bot commented Dec 9, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@fur0ut0 fur0ut0 force-pushed the fix/optional_package_start_uri branch from 4a8a006 to 78ae562 Compare December 9, 2024 07:02
@KazuCocoa
Copy link
Member

Then, will you make package in https://github.com/appium/appium-uiautomator2-driver?tab=readme-ov-file#mobile-deeplink optional with this?

@fur0ut0
Copy link
Contributor Author

fur0ut0 commented Dec 9, 2024

Then, will you make package in https://github.com/appium/appium-uiautomator2-driver?tab=readme-ov-file#mobile-deeplink optional with this?

Sure.

May I ask when I should create PR for that? I'm concerned about dependency.

@mykola-mokhnach mykola-mokhnach merged commit be54566 into appium:master Dec 10, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
## [12.7.3](v12.7.2...v12.7.3) (2024-12-10)

### Bug Fixes

* Make package of startUri optional ([#776](#776)) ([be54566](be54566))
Copy link

🎉 This PR is included in version 12.7.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@KazuCocoa
Copy link
Member

You could use 12.7.3+ @fur0ut0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants