add localeScript capability to set script in locale #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
changed the title
lib/android-helpers.js
Outdated
| if (!await adb.ensureCurrentLocale(language, country)) { | ||
| throw new Error(`Failed to set language: ${language} and country: ${country}`); | ||
| if (!await adb.ensureCurrentLocale(language, country, script)) { | ||
| let message; |
There was a problem hiding this comment.
you can use a ternary operator here
|
@KazuCocoa Might it be that something has happened to Unlock script after the SDK tools version has been bumped for Appium Settings: https://travis-ci.org/appium/appium-android-driver/jobs/450112540 ? |
|
mmm, in my locale, below command worked... let me see. |
|
Maybe it does not work with API 20 emulator (the one used for this job)? |
|
API 19 and 21, arm emulator also worked 🤔 |
mykola-mokhnach
approved these changes
Nov 5, 2018
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on appium/appium-adb#372
After merging the PR, we should update the module.
In this PR, I've introduced
localeScriptcapability to setHansinzh-Hans-CN. The middle one is namedscriptin the Locale term. It only available in Android so far.