Calls helpers.ensureDeviceLocale if the opts has either language or locale #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -635,7 +635,9 @@ helpers.initDevice = async function (adb, opts) { | |||
| await helpers.setMockLocationApp(adb, SETTINGS_HELPER_PKG_ID); | |||
| } | |||
|
|
|||
| await helpers.ensureDeviceLocale(adb, opts.language, opts.locale, opts.localeScript); | |||
| if (opts.language || opts.locale) { | |||
There was a problem hiding this comment.
should it be || or && ?
There was a problem hiding this comment.
|| is fine here since if users set only language (or locale), then we should show a message in ensureDeviceLocale to guide them.
We can skip calling the ensureDeviceLocale when they do not specify both language and locale in their capability.
mykola-mokhnach
approved these changes
Dec 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://appium.slack.com/archives/C02956V3H/p1543739923001400
languageorlocaleis mandatory.localeScriptis option.We can reduce warning messages for no
languageand nolocalecase.