Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not consider app as temporary if relative app path is provided #479

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Do not consider app as temporary if relative app path is provided #479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/driver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,8 @@ class AndroidDriver extends BaseDriver {
if (this.opts.app) {
// find and copy, or download and unzip an app url or path
this.opts.app = await this.helpers.configureApp(this.opts.app, APP_EXTENSION);
this.opts.appIsTemp = caps.app !== this.opts.app; // did we make a temporary copy?
this.opts.appIsTemp = this.opts.app && await fs.exists(this.opts.app)
&& !await util.isSameDestination(caps.app, this.opts.app);
await this.checkAppPresent();
} else if (this.appOnDevice) {
// the app isn't an actual app file but rather something we want to
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"appium-adb": "^6.27.0",
"appium-base-driver": "^3.0.0",
"appium-chromedriver": "^4.8.0",
"appium-support": "^2.24.1",
"appium-support": "^2.25.0",
"asyncbox": "^2.0.4",
"bluebird": "^3.4.7",
"io.appium.settings": "^2.10.0",
Expand Down