Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add network_connection to NO_PROXY #531

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Add network_connection to NO_PROXY #531

merged 1 commit into from
Apr 9, 2019

Conversation

dpgraham
Copy link
Contributor

@dpgraham dpgraham commented Apr 8, 2019

No description provided.

mykola-mokhnach
mykola-mokhnach approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same should be done for uia2 and espresso

@dpgraham
Copy link
Contributor Author

dpgraham commented Apr 9, 2019

@mykola-mokhnach already there for UIA2... I'll check Espresso tomorrow morning, but should be there too. Prob just a cut-and-paste from UIA2.

@dpgraham
Copy link
Contributor Author

dpgraham commented Apr 9, 2019

cc: @vrunoa

@dpgraham dpgraham merged commit cf859d1 into master Apr 9, 2019
@dpgraham dpgraham deleted the dpgraham-no-proxy-network-connection branch April 9, 2019 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

@imurchie imurchie Awaiting requested review from imurchie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpgraham @mykola-mokhnach