Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable touch actions in web view context #534

Merged
merged 3 commits into from
Apr 19, 2019
Merged

Enable touch actions in web view context #534

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db11871
Enable touch actions in web view context
mykola-mokhnach Apr 19, 2019
381a683
Tune texts
mykola-mokhnach Apr 19, 2019
8ae20b4
Remove logs
mykola-mokhnach Apr 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions lib/commands/touch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,6 @@ helpers.performGesture = async function performGesture (gesture) {
};

commands.performTouch = async function performTouch (gestures) {
if (this.isWebContext()) {
throw new errors.NotYetImplementedError();
}

// press-wait-moveTo-release is `swipe`, so use native method
if (gestures.length === 4 &&
gestures[0].action === 'press' &&
Expand Down Expand Up @@ -286,10 +282,6 @@ helpers.parseTouch = async function parseTouch (gestures, multi) {


commands.performMultiAction = async function performMultiAction (actions, elementId) {
if (this.isWebContext()) {
throw new errors.NotYetImplementedError();
}

// Android needs at least two actions to be able to perform a multi pointer gesture
if (actions.length === 1) {
throw new Error('Multi Pointer Gestures need at least two actions. ' +
Expand Down