This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fix: getCurrentSessions for cloud providers using Basic Auth #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KazuCocoa I need a review on this PR as well, it's similar to the other one except that it's forked out of 1.20 branch so that we can release this with Appium Desktop v1.20 |
KazuCocoa
reviewed
Feb 14, 2021
app/main/appium.js
Outdated
| try { | ||
| const res = await request(`http${ssl ? 's' : ''}://${host}:${port}${appiumPath}/sessions`); | ||
| if (username && accessKey) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
Made these changes
KazuCocoa
approved these changes
Feb 15, 2021
|
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/wd/hub/sessionsrequests i.e. forgetCurrentSessionsBROWSERSTACK_PORTset in the environment variables for defining the port and setting SSL to true if the port is 443.