This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlipps
approved these changes
Mar 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you post some screenshots though?
dpgraham
force-pushed
the
dpgraham-allow-unauthorized
branch
from
March 19, 2018 20:25
66bcd92
to
0ab209d
Compare
@jlipps There's another open issue for setting a proxy. Maybe I should add an advanced settings section that includes both proxy and untrusted SSL checkbox |
* Add 'proxy' to configureHttp in appium.js * Make `rejectUnauthroized` and `proxy` advanced form fields hidden in a collapsible view underneath the server settings
@jlipps When you have a chance can you look at the screenshots and have another look at this PR? I added an 'Advanced Settings' collapsible where the user can specify |
@jlipps Can you take a look at the screenshots again? I need to get this into a release soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rejectUnauthorized
http config onadmc/wd
(https://github.com/appium/appium-desktop/issues/390)