Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Allow unauthorized SSL and Proxy #469

Merged
merged 6 commits into from
Apr 2, 2018
Merged

Conversation

dpgraham
Copy link
Contributor

  • This is a checkbox that allows users to accept untrusted SSL certificates (for users behind firewall).
  • This checkbox is added to Sauce, TestObject and Headspin (let me know if you think there's a better way of doing this in the UI)
  • When set, it turns off the rejectUnauthorized http config on admc/wd

(https://github.com/appium/appium-desktop/issues/390)

@dpgraham dpgraham requested a review from jlipps March 19, 2018 17:18
Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you post some screenshots though?

@dpgraham
Copy link
Contributor Author

screen shot 2018-03-19 at 1 23 29 pm
screen shot 2018-03-19 at 1 23 52 pm
screen shot 2018-03-19 at 1 23 40 pm
screen shot 2018-03-19 at 1 23 46 pm

@dpgraham dpgraham force-pushed the dpgraham-allow-unauthorized branch from 66bcd92 to 0ab209d Compare March 19, 2018 20:25
@dpgraham
Copy link
Contributor Author

@jlipps There's another open issue for setting a proxy. Maybe I should add an advanced settings section that includes both proxy and untrusted SSL checkbox

@dpgraham
Copy link
Contributor Author

Something like this:

screen shot 2018-03-19 at 2 37 13 pm

screen shot 2018-03-19 at 2 37 49 pm

* Add 'proxy' to configureHttp in appium.js
* Make `rejectUnauthroized` and `proxy` advanced form fields hidden in a collapsible view underneath the server settings
@dpgraham
Copy link
Contributor Author

@jlipps When you have a chance can you look at the screenshots and have another look at this PR? I added an 'Advanced Settings' collapsible where the user can specify Allow Unauthorized and set a proxy server setting (related to https://github.com/appium/appium-desktop/issues/242)

@dpgraham dpgraham changed the title Allow unauthorized SSL Allow unauthorized SSL and Proxy Mar 21, 2018
@dpgraham
Copy link
Contributor Author

@jlipps Can you take a look at the screenshots again? I need to get this into a release soon.

@dpgraham dpgraham merged commit 26eeee1 into master Apr 2, 2018
@dpgraham dpgraham deleted the dpgraham-allow-unauthorized branch April 2, 2018 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants