Implement Espresso contrib mobile commands #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...rver/app/src/androidTest/java/io/appium/espressoserver/lib/handlers/DrawerActionHandler.java
Outdated
Show resolved
Hide resolved
...o-server/app/src/androidTest/java/io/appium/espressoserver/lib/model/DrawerActionParams.java
Outdated
Show resolved
Hide resolved
espresso-server/app/src/androidTest/java/io/appium/espressoserver/lib/handlers/NavigateTo.java
Outdated
Show resolved
Hide resolved
...esso-server/app/src/androidTest/java/io/appium/espressoserver/lib/handlers/ScrollToPage.java
Outdated
Show resolved
Hide resolved
...esso-server/app/src/androidTest/java/io/appium/espressoserver/lib/handlers/ScrollToPage.java
Outdated
Show resolved
Hide resolved
...esso-server/app/src/androidTest/java/io/appium/espressoserver/lib/handlers/ScrollToPage.java
Outdated
Show resolved
Hide resolved
...esso-server/app/src/androidTest/java/io/appium/espressoserver/lib/handlers/ScrollToPage.java
Outdated
Show resolved
Hide resolved
espresso-server/app/src/androidTest/java/io/appium/espressoserver/lib/handlers/SetDate.java
Outdated
Show resolved
Hide resolved
espresso-server/app/src/androidTest/java/io/appium/espressoserver/lib/handlers/SetDate.java
Show resolved
Hide resolved
espresso-server/app/src/androidTest/java/io/appium/espressoserver/lib/handlers/SetTime.java
Show resolved
Hide resolved
espresso-server/app/src/androidTest/java/io/appium/espressoserver/lib/model/SetTimeParams.java
Outdated
Show resolved
Hide resolved
lib/commands/general.js
Outdated
| commands.mobileNavigateTo = async function (opts = {}) { | ||
| let {element, menuItemId} = assertRequiredOptions(opts, ['menuItemId', 'element']); | ||
|
|
||
| let menuItemIdAsNumber = parseInt(menuItemId, 0); |
There was a problem hiding this comment.
@dpgraham how about fixing the second argument of parseInt?
* Renamed 'Screenshot' to 'ScreenshotHandler' to avoid naming conflict
dpgraham
force-pushed
the
dpgraham-espresso-mobile-commands
branch
from
778aa2f to
38ea8ba
Compare
|
Fixes pushed. I'm using the validate.js library to validate scrollTo parameters now. |
espresso-server/app/src/androidTest/java/io/appium/espressoserver/lib/handlers/NavigateTo.java
Show resolved
Hide resolved
...esso-server/app/src/androidTest/java/io/appium/espressoserver/lib/handlers/ScrollToPage.java
Outdated
Show resolved
Hide resolved
|
LGTM, only one comment is left (parseInt arg) |
This was referenced Dec 2, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mobile commands:
setDate,setTime,navigateTo,scrollToPage,openDrawer,closeDrawer(connect with: #323)