Implement swipe and click actions #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...so-server/app/src/androidTest/java/io/appium/espressoserver/lib/helpers/GsonParserHelpers.kt
Outdated
Show resolved
Hide resolved
...so-server/app/src/androidTest/java/io/appium/espressoserver/lib/helpers/GsonParserHelpers.kt
Outdated
Show resolved
Hide resolved
espresso-server/app/src/androidTest/java/io/appium/espressoserver/lib/http/Router.java
Outdated
Show resolved
Hide resolved
...esso-server/app/src/androidTest/java/io/appium/espressoserver/lib/model/MobileSwipeParams.kt
Outdated
Show resolved
Hide resolved
...so-server/app/src/androidTest/java/io/appium/espressoserver/lib/helpers/GsonParserHelpers.kt
Show resolved
Hide resolved
|
Fixes pushed |
espresso-server/app/src/test/java/io/appium/espressoserver/test/model/MobileSwipeTest.kt
Outdated
Show resolved
Hide resolved
espresso-server/app/build.gradle
Outdated
| @@ -14,8 +16,7 @@ android { | |||
|
|
|||
| buildTypes { | |||
| release { | |||
| minifyEnabled false | |||
| proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro' | |||
| minifyEnabled true | |||
There was a problem hiding this comment.
why should we enable that? this setting might corrupt class names, so they will not be visible for reflection calls
KazuCocoa
approved these changes
Jan 18, 2019
|
That's right @KazuCocoa ... do you or @mykola-mokhnach have any ideas why that's happening? I'm going to dig into tomorrow to see what happened. |
|
@dpgraham Most likely because of Travis slowness. How about moving the tests to Azure CI? @SrinivasanTarget has already done this for java client and the performance is good: |
espresso-server/app/build.gradle
Outdated
| } | ||
| repositories { |
There was a problem hiding this comment.
should we repeat that in both scripts?
mykola-mokhnach
approved these changes
Jan 18, 2019
dpgraham
force-pushed
the
dpgraham-general-swipe-and-click-actions
branch
from
6e2a1c5 to
c62c122
Compare
dpgraham
force-pushed
the
dpgraham-general-swipe-and-click-actions
branch
from
a6095cd to
38bed6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.ktfiles..ktand.javaare interoperable, so no concern about using both simultaneouslymobile: swipemobile endpoint. Can now pass parameters{swiper, startCoordinates, endCoordinates, ...},mobile: clickActionmobile endpoint which takes parameters{element, tapper, coordinatesProvider, precisionDescriber, inputDevice, buttonState}