fix: handle location command as case insensitive (#407)

appium · Dec 4, 2023 · fa060a4 · fa060a4
1 parent 0a9b22b
commit fa060a4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/extensions/permissions.js b/lib/extensions/permissions.js
@@ -116,7 +116,9 @@ async function setAccess (simctl, udid, bundleId, permissionsMapping) {
     if (!PERMISSIONS_APPLIED_VIA_SIMCTL.includes(serviceName)) {
       wixPermissions[serviceName] = permissionsMapping[serviceName];
     } else {
-      switch (permissionsMapping[serviceName]) {
+      // xcrun simctl privacy expects to be lower case while AppleSimulatorUtils is upper case.
+      // To keep the compatibility,  we should convert here to lower case explicitly.
+      switch (_.toLower(permissionsMapping[serviceName])) {
         case STATUS.YES:
           grantPermissions.push(serviceName);
           break;

diff --git a/test/functional/simulator-e2e-specs.js b/test/functional/simulator-e2e-specs.js
@@ -354,7 +354,7 @@ describe('advanced features', function () {
     it('should set and get with simctrl privacy command', async function () {
       // no exceptions
       await expect(sim.setPermission('com.apple.Maps', 'location', 'yes')).not.to.be.rejected;
-      await expect(sim.setPermission('com.apple.Maps', 'location', 'no')).not.to.be.rejected;
+      await expect(sim.setPermission('com.apple.Maps', 'location', 'NO')).not.to.be.rejected;
       await expect(sim.setPermission('com.apple.Maps', 'location', 'unset')).not.to.be.rejected;
       await expect(sim.setPermission('com.apple.Maps', 'location', 'unsupported')).to.be.rejected;
     });