Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Apply minor dependency version tunings #340

Merged
merged 1 commit into from
Oct 19, 2023
Merged

chore: Apply minor dependency version tunings #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/unit-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,6 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm run lint
- run: npm run test
7 changes: 1 addition & 6 deletions bin/web_inspector_proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint-disable no-console */
import { exec, SubProcess } from 'teen_process';
import { SubProcess } from 'teen_process';
import { plist, util } from '@appium/support';
import { asyncify } from 'asyncbox';
import B from 'bluebird';
Expand All @@ -12,10 +12,6 @@ async function getSocket (udid) {
return await sim.getWebInspectorSocket();
}

async function moveSocket (socket) { // eslint-disable-line no-unused-vars
await exec('mv', [socket, `${socket}.original`]);
}

function printRecord (lines) {
const header = lines.shift();
console.log(header);
Expand Down Expand Up @@ -103,7 +99,6 @@ async function main () {
const udid = _.last(process.argv);
const s = await getSocket(udid);
console.log('Simulator web inspector socket:', s);
// await moveSocket(s);
await startSoCat(s);
}

Expand Down
3 changes: 1 addition & 2 deletions lib/remote-debugger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import _ from 'lodash';
import B from 'bluebird';
import path from 'path';
import AsyncLock from 'async-lock';
import RpcClient from './rpc/rpc-client';

const REMOTE_DEBUGGER_PORT = 27753;
const SAFARI_BUNDLE_ID = 'com.apple.mobilesafari';
Expand Down Expand Up @@ -38,7 +37,7 @@ class RemoteDebugger extends EventEmitter {
pageLoadDelay;
/** @type {B<void>} */
navigationDelay;
/** @type {RpcClient?} */
/** @type {import('./rpc/rpc-client').default?} */
rpcClient;

// events
Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@
},
"devDependencies": {
"@appium/eslint-config-appium": "^8.0.4",
"@appium/eslint-config-appium-ts": "^0.3.1",
"@appium/tsconfig": "^0.3.0",
"@appium/types": "^0.13.2",
"@appium/eslint-config-appium-ts": "^0.x",
"@appium/tsconfig": "^0.x",
"@appium/types": "^0.x",
"@semantic-release/changelog": "^6.0.1",
"@semantic-release/git": "^10.0.1",
"@types/bluebird": "^3.5.38",
Expand All @@ -91,7 +91,7 @@
"@types/node": "^20.4.7",
"@types/sinon": "^10.0.16",
"@types/sinon-chai": "^3.2.9",
"@types/teen_process": "2.0.0",
"@types/teen_process": "^2.0.0",
"@typescript-eslint/eslint-plugin": "^5.62.0",
"@typescript-eslint/parser": "^5.62.0",
"appium-ios-simulator": "^5.0.1",
Expand Down
Loading