Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump up ios versions, device, xcode and macos version under test #347

Merged

Conversation

mwakizaka
Copy link
Contributor

@mwakizaka mwakizaka commented Nov 19, 2023

although I'm not familiar with GitHub actions, updated based on https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md#xcode

@mwakizaka
Copy link
Contributor Author

will check later

 1) Safari remote debugger
       should be able to call 'selectApp' after already connecting to app:
     Error: No apps connected
      at /Users/runner/work/appium-remote-debugger/appium-remote-debugger/test/functional/safari-e2e-specs.js:109:13
      at async wrapped (node_modules/asyncbox/lib/asyncbox.js:93:13)
      at async retry (node_modules/asyncbox/lib/asyncbox.js:66:13)
      at async retryInterval (node_modules/asyncbox/lib/asyncbox.js:103:10)
      at async connect (test/functional/safari-e2e-specs.js:104:12)
      at async Context.<anonymous> (test/functional/safari-e2e-specs.js:214:5)

  2) Safari remote debugger
       should be able to get console logs from a remote page:
     TypeError: Cannot read properties of null (reading 'on')
      at /Users/runner/work/appium-remote-debugger/appium-remote-debugger/lib/rpc/rpc-client-simulator.js:134:19
      at Promise.cancellationExecute [as _execute] (node_modules/bluebird/js/release/debuggability.js:406:9)
      at Promise._resolveFromExecutor (node_modules/bluebird/js/release/promise.js:518:18)
      at new Promise (node_modules/bluebird/js/release/promise.js:103:10)
      at RpcClientSimulator.sendMessage (lib/rpc/rpc-client-simulator.js:124:18)
      at /Users/runner/work/appium-remote-debugger/appium-remote-debugger/lib/rpc/rpc-client.js:324:32
      at Promise.cancellationExecute [as _execute] (node_modules/bluebird/js/release/debuggability.js:406:9)
      at Promise._resolveFromExecutor (node_modules/bluebird/js/release/promise.js:518:18)
      at new Promise (node_modules/bluebird/js/release/promise.js:103:10)
      at RpcClientSimulator.sendToDevice (lib/rpc/rpc-client.js:234:18)
      at RpcClientSimulator.send (lib/rpc/rpc-client.js:204:25)
      at RemoteDebugger.setConnectionKey (lib/mixins/connect.js:44:24)
      at /Users/runner/work/appium-remote-debugger/appium-remote-debugger/test/functional/safari-e2e-specs.js:108:16
      at wrapped (node_modules/asyncbox/lib/asyncbox.js:93:19)
      at retry (node_modules/asyncbox/lib/asyncbox.js:66:19)
      at async retryInterval (node_modules/asyncbox/lib/asyncbox.js:103:10)
      at async connect (test/functional/safari-e2e-specs.js:104:12)
      at async Context.<anonymous> (test/functional/safari-e2e-specs.js:227:5)



Error: Process completed with exit code 2.

Copy link
Contributor

@mykola-mokhnach mykola-mokhnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually add ci: prefix to such PRs

@mwakizaka mwakizaka changed the title test: bump up ios versions, device, xcode and macos version under test ci: bump up ios versions, device, xcode and macos version under test Dec 10, 2023
@mwakizaka
Copy link
Contributor Author

finally passed 🎉

@mwakizaka
Copy link
Contributor Author

@mykola-mokhnach @KazuCocoa
Excuse me, may I ask you to check this PR?

@mykola-mokhnach mykola-mokhnach merged commit 5f5f912 into appium:master Dec 25, 2023
7 checks passed
@mykola-mokhnach
Copy link
Contributor

Thanks for working on it @mwakizaka
Feel free to ping us anytime regarding reviews in the Appium Slack channel (or provide your email address if you are still not there)

@mwakizaka mwakizaka deleted the test/bump_up_ios_versions_etc branch December 25, 2023 23:01
@mwakizaka
Copy link
Contributor Author

Thanks for working on it @mwakizaka Feel free to ping us anytime regarding reviews in the Appium Slack channel (or provide your email address if you are still not there)

Thank you! Please use mwakizaka0108@gmail.com

Copy link

🎉 This PR is included in version 10.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants