Add the eventloopIdleDelaySec capability (wdaEventloopIdleDelay for users)
#881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
approved these changes
Mar 1, 2019
KazuCocoa
reviewed
Mar 2, 2019
README.md
Outdated
| @@ -162,6 +162,7 @@ Differences noted here | |||
| |`permissions`| Allows to set permissions for the specified application bundle on Simulator only. The capability value is expected to be a valid JSON string with `{"<bundleId1>": {"<serviceName1>": "<serviceStatus1>", ...}, ...}` format. It is required that `applesimutils` package is installed and available in PATH. The list of available service names and statuses can be found at https://github.com/wix/AppleSimulatorUtils. | e. g. `{"com.apple.mobilecal": {"calendar": "YES"}}` | | |||
| |`screenshotQuality`| Changes the quality of phone display screenshots following [xctest/xctimagequality](https://developer.apple.com/documentation/xctest/xctimagequality?language=objc) Default value is `1`. `0` is the highest and `2` is the lowest quality. You can also change it via [settings](https://github.com/appium/appium/blob/master/docs/en/advanced-concepts/settings.md) command. `0` might cause OutOfMemory crash on high-resolution devices like iPad Pro. | e.g. `0`, `1`, `2` | | |||
| |`skipLogCapture`|Skips to start capturing logs such as crash, system, safari console and safari network. It might improve performance such as network. Log related commands will not work. Defaults to `false`. |`true` or `false`| | |||
| |`eventloopIdleDelaySec`|Delays the invocation of `-[XCUIApplicationProcess setEventLoopHasIdled:]` by the number of seconds specified with this capability. This can help quiescence apps that fail to do so for no obvious reason (and creating a session fails for that reason). This increases the time for session creation because `-[XCUIApplicationProcess setEventLoopHasIdled:]` is called multiple times. If you enable this capability start with at least `3` seconds and try increasing it, if creating the session still fails. Defaults to `0`. |e.g. `5`| | |||
KazuCocoa
approved these changes
Mar 2, 2019
|
I think the name of this is confusing. I would add a WDA in there somewhere, to distinguish from, say, the Node event loop. |
KazuCocoa
reviewed
Mar 5, 2019
lib/desired-caps.js
Outdated
| @@ -168,6 +168,9 @@ let desiredCapConstraints = _.defaults({ | |||
| skipLogCapture: { | |||
| isBoolean: true | |||
| }, | |||
| eventloopIdleDelaySec: { | |||
There was a problem hiding this comment.
wdaEventloopIdleDelay here as README?
There was a problem hiding this comment.
Yes of course. Mixed the two names up...
lib/driver.js
Outdated
| @@ -844,6 +844,7 @@ class XCUITestDriver extends BaseDriver { | |||
| let maxTypingFrequency = util.hasValue(this.opts.maxTypingFrequency) ? this.opts.maxTypingFrequency : 60; | |||
| let shouldUseSingletonTestManager = util.hasValue(this.opts.shouldUseSingletonTestManager) ? this.opts.shouldUseSingletonTestManager : true; | |||
| let shouldUseTestManagerForVisibilityDetection = false; | |||
| let wdaEventloopIdleDelay = this.opts.eventloopIdleDelaySec || 0; | |||
There was a problem hiding this comment.
let eventloopIdleDelaySec = this.opts. wdaEventloopIdleDelay || 0 and eventloopIdleDelaySec as a desired capability in create session below?
KazuCocoa
approved these changes
Mar 5, 2019
There was a problem hiding this comment.
looks good to me. appium/WebDriverAgent@f6a3d66...5896cce has no changes, so is this no problem??
|
@KazuCocoa the commit for the WDA submodule was already bumped to the most recent commit. And the required changes were already merged here: appium/WebDriverAgent@5896cce so there's no need to do anything else here |
jlipps
approved these changes
Mar 5, 2019
KazuCocoa
changed the title
eventloopIdleDelaySec capabilityeventloopIdleDelaySec capability (wdaEventloopIdleDelay for users)
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
* updated WDA submodule * added the eventloopIdleDelaySec capability * added documentation * replaced the ternary if * renamed capability * fixed the naming mixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for handling the
eventloopIdleDelaySeccapability in WDA (appium/WebDriverAgent#140).