-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toggle touch id enrollment #521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @KazuCocoa should review as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented two points. Others looks good 👍
My comments will fix CI.
lib/appium_lib/common/command.rb
Outdated
@@ -54,6 +54,7 @@ module Commands | |||
|
|||
# iOS | |||
touch_id: [:post, 'session/:session_id/appium/simulator/touch_id'.freeze] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add ,
at the end of this line
lib/appium_lib/device/device.rb
Outdated
@@ -340,6 +343,13 @@ def touch_id(match = true) | |||
end | |||
|
|||
# TODO: TEST ME | |||
add_endpoint_method(:toggle_touch_id_enrollment) do | |||
def toggle_touch_id_enrollment() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove ()
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.