Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle touch id enrollment #521

Merged
merged 4 commits into from
Mar 28, 2017
Merged

Conversation

dpgraham
Copy link
Contributor

No description provided.

@dpgraham dpgraham requested a review from KazuCocoa March 27, 2017 18:43
Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @KazuCocoa should review as well.

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented two points. Others looks good 👍
My comments will fix CI.

@@ -54,6 +54,7 @@ module Commands

# iOS
touch_id: [:post, 'session/:session_id/appium/simulator/touch_id'.freeze]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add , at the end of this line

@@ -340,6 +343,13 @@ def touch_id(match = true)
end

# TODO: TEST ME
add_endpoint_method(:toggle_touch_id_enrollment) do
def toggle_touch_id_enrollment()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove ()

@KazuCocoa KazuCocoa added this to the v9.4.0 milestone Mar 27, 2017
@dpgraham
Copy link
Contributor Author

Done

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dpgraham dpgraham merged commit 4ae0815 into master Mar 28, 2017
This was referenced Mar 28, 2017
@KazuCocoa KazuCocoa modified the milestones: v9.3.6, v9.4.0 Mar 30, 2017
@KazuCocoa KazuCocoa deleted the dpgraham-toggle-touch-id-enrollment branch April 6, 2017 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants