Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golang: ReadTransaction should expose TransactionOptions #6265

Closed
johscheuer opened this issue Jan 20, 2022 · 1 comment · Fixed by #6318
Closed

Golang: ReadTransaction should expose TransactionOptions #6265

johscheuer opened this issue Jan 20, 2022 · 1 comment · Fixed by #6318
Assignees
@sfc-gh-anoyes

Comments

@johscheuer
Copy link
Contributor

It would be useful if the ReadTransaction would expose the TransactionOptions like a normal transaction. that would allow users to use a read transaction to read from the system key space (e.g. the management API in the future). Without that we are not able to set the transaction.Options().SetAccessSystemKeys() option to allow access to the system key space. We would like to use read transactions in our implementation, e.g. in the Kubernetes FDB operator to ensure we are only reading from the system key space for most of our operations.
sfc-gh-anoyes added a commit to sfc-gh-anoyes/foundationdb that referenced this issue Jan 29, 2022
@sfc-gh-anoyes
go: Allow access to TransactionOptions from ReadTransaction
cfbdcb5 
Closes apple#6265
@sfc-gh-anoyes sfc-gh-anoyes mentioned this issue Jan 29, 2022
Merged
5 tasks
@sfc-gh-anoyes
Copy link
Collaborator

that would allow users to use a read transaction to read from the system key space (e.g. the management API in the future)

I think you're confusing the system key space [\xff, \xff\xff) with the special key space [\xff\xff, \xff\xff\xff). The management API in the future will be exposed through the special key space.

That said, it does make sense to have transaction options exposed in ReadTransaction and other bindings (e.g. the java bindings) do that.

@johscheuer I have a draft PR which I think resolves this issue. Let me know if this works for you. #6318

sfc-gh-anoyes added a commit that referenced this issue Feb 9, 2022
@sfc-gh-anoyes
Allow access to transaction options through a go ReadTransaction in…
863449c 
…terface (#6318)

* Run go unit tests in ctest

* Remove unnecessary cgo directives

* go: Allow access to TransactionOptions from ReadTransaction

Closes #6265

* Try go get instead of go install

My understanding is that this should download dependencies (e.g. xerrors)

* Add -d flag to match go command for building libraries

* Avoid concurrent calls to `go get`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-anoyes sfc-gh-anoyes

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@johscheuer @sfc-gh-anoyes