-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EaR: Remove unused CODE_PROBE handling encrpyiton header flag version #10020
Merged
sfc-gh-ahusain
merged 1 commit into
apple:main
from
sfc-gh-ahusain:ahusain-fdbcore-4634
Apr 20, 2023
Merged
EaR: Remove unused CODE_PROBE handling encrpyiton header flag version #10020
sfc-gh-ahusain
merged 1 commit into
apple:main
from
sfc-gh-ahusain:ahusain-fdbcore-4634
Apr 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description Patch removes an unused CODE_PROBE checking the encryption header being read flag version is valid, given the flag-version is determined by peeking into std::variant index and we only have version-1 supported, for now converted the check to an ASSERT Testing EncryptionUnitTests.toml EncryptionOps.toml BlobGranuleCorrectness/Clean.toml
sfc-gh-nwijetunga
approved these changes
Apr 19, 2023
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Doxense CI Report for Windows 10
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
sfc-gh-ahusain
added a commit
to sfc-gh-ahusain/foundationdb
that referenced
this pull request
Apr 20, 2023
…apple#10020) Description Patch removes an unused CODE_PROBE checking the encryption header being read flag version is valid, given the flag-version is determined by peeking into std::variant index and we only have version-1 supported, for now converted the check to an ASSERT Testing EncryptionUnitTests.toml EncryptionOps.toml BlobGranuleCorrectness/Clean.toml (cherry picked from commit a099d37)
5 tasks
sfc-gh-akejriwal
pushed a commit
that referenced
this pull request
Apr 21, 2023
…#10020) (#10024) Description Patch removes an unused CODE_PROBE checking the encryption header being read flag version is valid, given the flag-version is determined by peeking into std::variant index and we only have version-1 supported, for now converted the check to an ASSERT Testing EncryptionUnitTests.toml EncryptionOps.toml BlobGranuleCorrectness/Clean.toml (cherry picked from commit a099d37)
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Patch removes an unused CODE_PROBE checking the encryption header being read flag version is valid, given the flag-version is determined by peeking into std::variant index and we only have version-1 supported, for now converted the check to an ASSERT
Testing
EncryptionUnitTests.toml
EncryptionOps.toml
BlobGranuleCorrectness/Clean.toml
Replace this text with your description here...
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormain
if this is the youngest branch)