Update Redwood #2996
Merged
Update Redwood #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
April 1, 2020 02:41
… viewing the file.
…eeks using a pool of cursors with different mirrors to test the speed of having to decode DeltaTree nodes much more often.
…d 4 byte integer offsets for larger.
…rsor and InternalCursor updated to be correct (but not optimal) for new record definition. DeltaTree::seek* refactored to support more seek types and with minor code duplication. Lots of debug output improvements. Refactored how bulk pages are written and introduced fill factor percentage (though since internal pages are not yet incrementally modified this is temporarily worse for those).
…reached was not correct in a couple of ways.
…sing variable length integers with extension bits. Instead, two (recently available) header bits now indicate which of four struct definitions the Delta is using. The resulting code is a bit repetitive but also easier to read and 15% faster in the RedwoodRecord Delta speed test vs the old version.
…here and with a more useful return value.
…he version field scheme. Simplified it to select between different fixed size native integer formats.
…e root page references.
…of unpredictability in node overhead sizes which could lead to serializing a tree that doesn't fit into its destination page buffer. WritePages() now skips the prefix common to all records in the input set when calling deltaSize() to estimate resulting DeltaTree serialized sizes.
…byte option as it is not very useful.
…mmitSubtree() which should no longer be possible due to recent changes. This is mainly to test assumptions being made in the commitSubtree() refactor in progress. Set simulation to always choose Redwood, will revert for PR.
|
@fdb-build test this please |
added 3 commits
April 23, 2020 04:23
…urn only 1 page but not attempt to reuse the existing BTreePageID for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeltaTree now has large/small mode, large KV pairs are no longer chunked into multiple RedwoodRecords, instead oversized pages with large DeltaTrees are used. RedwoodRecord refactored to remove chunking fields and logic, delta format refactored to be simpler and faster, and version is encoded as a delta independent of key. Page building now uses a fill factor.