-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log SubCode and Severity for RocksDB erros. #5515
Conversation
AWS CodeBuild CI Report
|
67cf33f
to
15017bc
Compare
Rebase to clear format errors. |
AWS CodeBuild CI Report
|
AWS CodeBuild CI Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the initial version.
SevError will put the process to a bad state.
If rocksDB has a recoverable error AND FDB decides to wait for RocksDB to recover instead of replicate it, we should output SevWarning instead of SevError
Ack. We will need to decide the log level based on the severity. |
Log SubCode and Severity for RocksDB erros (#5515)
Example
trace.127.0.0.1.4503.1630440279.a5Q2jo.0.1.xml:<Event Severity="40" ErrorKind="Unset" Time="1630440291.196540" DateTime="2021-08-31T20:04:51Z" Type="RocksDBError" ID="0000000000000000" Error="IO error: No space left on device" Method="Commit" RocksDBSeverity="0" SubCode="4" ThreadID="16869869807533468410" Backtrace="addr2line -e fdbserver.debug -p -C -f -i 0x2becf2c 0x2bec0f0 0x2bec4d1 0xf29787 0xf2b7e2 0x2b68d46 0x2b6a285 0x7fb2598fbea5" Machine="127.0.0.1:4503" LogGroup="default" Roles="CC,CP,DD,GP,MS,RK,RV,SS,TL" />
Code-Reviewer Section
The general guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormaster
if this is the youngest branch)