Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClientCount to ClusterControllerMetrics #5748

Merged

Conversation

sfc-gh-abeamon
Copy link
Collaborator

@sfc-gh-abeamon sfc-gh-abeamon commented Oct 11, 2021

This adds a client count metric to ClusterControllerMetrics so that it can be viewed in logs in addition to status. This is implemented by iterating through the client map every minute and counting the clients. This is roughly the same procedure that the cluster controller does when it receives a status request.

Passed 10K correctness. Checked with a manual deployment that the client count increases and decreases correctly.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for macOS Catalina 10.15

  • CodeBuild project: foundationdb-pull-request-build-macos
  • Commit ID: 15f43ae
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 15f43ae
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants