Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added KeyBackedObjectMap and KeyBackedObjectProperty classes for storing serializable objects in FDB #5896

Merged
merged 3 commits into from
Nov 8, 2021
Merged

Added KeyBackedObjectMap and KeyBackedObjectProperty classes for storing serializable objects in FDB #5896

merged 3 commits into from
Nov 8, 2021

Conversation

sfc-gh-satherton
Copy link
Collaborator

Added KeyBackedObjectMap and KeyBackObjectProperty, which work like KeyBackedMap and KeyBackedProperty but use ObjectWriter/Reader for Value serialization so that the type can evolve over time.

Also cleaned up some existing lambdas using relatively (since original writing) new x=y syntax to avoid capturing this by reference in a more elegant way.

The new classes aren't used yet.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@sfc-gh-satherton
Cleaned up some lambda capture workaround since x=y captures weren't …
efa8f1e 
…available when these classes were originally written.
@sfc-gh-satherton
Added KeyBackedObjectMap and KeyBackObjectProperty, which work like K…
f48af72 
…eyBackedMap and KeyBackedProperty but use ObjectWriter/Reader for Value serialization so that the type can evolve over time.
@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for macOS Catalina 10.15

  • CodeBuild project: foundationdb-pr-macos
  • Commit ID: f48af72
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: f48af72
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@sfc-gh-satherton sfc-gh-satherton mentioned this pull request Nov 3, 2021
Closed
@sfc-gh-satherton sfc-gh-satherton requested review from sfc-gh-jslocum and removed request for sfc-gh-xwang November 3, 2021 03:59
@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for macOS Catalina 10.15

  • CodeBuild project: foundationdb-pr-macos
  • Commit ID: 27b542b
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: 27b542b
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@sfc-gh-satherton sfc-gh-satherton merged commit d97d968 into apple:master Nov 8, 2021
This was referenced Feb 10, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jslocum sfc-gh-jslocum sfc-gh-jslocum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-satherton @foundationdb-ci @sfc-gh-jslocum