Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling rocksdb metrics logger in simulation. #6122

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

neethuhaneesha
Copy link
Contributor

Enabling rocksdb metrics logger in simulation.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: d23b864
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@liquid-helium
Copy link
Contributor

Update with Joshua tests?

@neethuhaneesha
Copy link
Contributor Author

Update with Joshua tests?

20211207-232409-neethuhaneeshabingi-7a85912be2db42ef compressed=True data_size=28144398 duration=7790146 ended=100000 fail=2 fail_fast=10 max_runs=100000 pass=99998 priority=100 remaining=0 runtime=1:01:25 sanity=False started=100298 stopped=20211208-002534 submitted=20211207-232409 timeout=5400 username=neethuhaneeshabingi

These two failures are existing failures, irrespective of the change.

@neethuhaneesha neethuhaneesha merged commit 50ed545 into apple:master Dec 8, 2021
@neethuhaneesha neethuhaneesha deleted the enableMetricsLogger branch December 8, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants