Fix flaky ctest tests #6310
Merged
Fix flaky ctest tests #6310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doxense CI Report for Windows 10
|
AWS CodeBuild CI Report for macOS BigSur 11.5.2
|
AWS CodeBuild CI Report for Linux CentOS 7
|
This way we get a predictable 127.0.0.1 in the trace file name
calling fdb_network_stop sends a "close" message to the trace thread, but the network thread might can still be running and sending "flush" messages to the network thread. This change basically ignores any flushes that come after a close.
sfc-gh-anoyes
force-pushed
the
anoyes/fix-ctest-flakes
branch
from
134f07a
to
25caa34
Compare
sfc-gh-abeamon
approved these changes
Jan 28, 2022
| @@ -216,6 +217,9 @@ def kill(logger): | |||
|
|
|||
| @enable_logging() | |||
| def suspend(logger): | |||
| if not shutil.which("pidof"): | |||
| logger.debug("Skipping suspend test. Pidof not available") | |||
| return | |||
There was a problem hiding this comment.
Is this the case in our CI, such that we will stop running the test there?
There was a problem hiding this comment.
I remember we have it in the CI, not sure if it's changed.
But it's not available on macOS and makes the test fail on macOS.
Add this may make the test work on macOS I guess?
There was a problem hiding this comment.
This is the case in joshua agents, but in not CI. We could probably add pidof to the Joshua agents. I'll follow up on that
sfc-gh-clin
approved these changes
Jan 28, 2022
| @@ -216,6 +217,9 @@ def kill(logger): | |||
|
|
|||
| @enable_logging() | |||
| def suspend(logger): | |||
| if not shutil.which("pidof"): | |||
| logger.debug("Skipping suspend test. Pidof not available") | |||
| return | |||
There was a problem hiding this comment.
I remember we have it in the CI, not sure if it's changed.
But it's not available on macOS and makes the test fail on macOS.
Add this may make the test work on macOS I guess?
AWS CodeBuild CI Report for macOS BigSur 11.5.2
|
Doxense CI Report for Windows 10
|
AWS CodeBuild CI Report for Linux CentOS 7
|
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few sources of flakiness in our "ctest" tests. Flakiness found by running the tests many times in Joshua, using #6237
Code-Reviewer Section
The general guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormasterif this is the youngest branch)