Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tests #6333

Merged
merged 5 commits into from
Feb 9, 2022
Merged

Add missing tests #6333

merged 5 commits into from
Feb 9, 2022

Conversation

moulmahdi
Copy link
Collaborator

Add missing test files and enhance their detection

sfc-gh-mpilman
sfc-gh-mpilman previously approved these changes Feb 3, 2022
View reviewed changes
@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for macOS BigSur 11.5.2

  • CodeBuild project: foundationdb-pr-macos
  • Commit ID: d50ec42
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: d50ec42
  • Result: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)

sfc-gh-mpilman
sfc-gh-mpilman reviewed Feb 3, 2022
View reviewed changes
tests/CMakeLists.txt Outdated
@@ -201,6 +203,10 @@ if(WITH_PYTHON)
add_fdb_test(TEST_FILES rare/TransactionTagApiCorrectness.toml)
add_fdb_test(TEST_FILES rare/TransactionTagSwizzledApiCorrectness.toml)
add_fdb_test(TEST_FILES rare/WriteTagThrottling.toml)
add_fdb_test(TEST_FILES rare/AllSimUnitTests.toml)
add_fdb_test(TEST_FILES rare/Downgrade.toml)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
add_fdb_test(TEST_FILES rare/Downgrade.toml)
add_fdb_test(TEST_FILES rare/Downgrade.toml IGNORE)

To unblock you, I would suggest you ignore this for now. This test is broken, I don't know whether it is still needed.

@moulmahdi
Remove Downgrade test
f10b549 
This test seems broken
@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for macOS BigSur 11.5.2

  • CodeBuild project: foundationdb-pr-macos
  • Commit ID: e8b6fec
  • Result: FAILED
  • Error: reference not found for primary source and source version e8b6fec16ee2e0e4fd4cac2122da9292782b26ac
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: e8b6fec
  • Result: FAILED
  • Error: reference not found for primary source and source version e8b6fec16ee2e0e4fd4cac2122da9292782b26ac
  • Build Logs (available for 30 days)

sfc-gh-mpilman
sfc-gh-mpilman previously approved these changes Feb 3, 2022
View reviewed changes
@fdb-windows-ci
Copy link
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: f10b549
  • Result: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: a2bc991
  • Result: FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for macOS BigSur 11.5.2

  • CodeBuild project: foundationdb-pr-macos
  • Commit ID: 00d1532
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: 00d1532
  • Result: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for macOS BigSur 11.5.2

  • CodeBuild project: foundationdb-pr-macos
  • Commit ID: e6c16a5
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: e6c16a5
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@moulmahdi moulmahdi merged commit 23fa27c into apple:main Feb 9, 2022
@sfc-gh-mpilman sfc-gh-mpilman mentioned this pull request Feb 15, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-mpilman sfc-gh-mpilman sfc-gh-mpilman approved these changes

Assignees

@sfc-gh-mpilman sfc-gh-mpilman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moulmahdi @foundationdb-ci @fdb-windows-ci @sfc-gh-mpilman