Fixes for when getMappedRange cannot parse as tuple #6665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report for macOS BigSur 11.5.2
|
Doxense CI Report for Windows 10
|
AWS CodeBuild CI Report for Linux CentOS 7
|
sfc-gh-bvr
reviewed
Mar 24, 2022
flow/error_definitions.h
Outdated
| @@ -178,6 +178,10 @@ ERROR( blob_granule_not_materialized, 2037, "Blob Granule Read was not materiali | |||
| ERROR( get_mapped_key_values_has_more, 2038, "getMappedRange does not support continuation for now" ) | |||
| ERROR( get_mapped_range_reads_your_writes, 2039, "getMappedRange tries to read data that were previously written in the transaction" ) | |||
| ERROR( checkpoint_not_found, 2040, "Checkpoint not found" ) | |||
| ERROR( key_not_tuple, 2041, "The key cannot be parsed as a tuple" ); | |||
| ERROR( value_not_tuple, 2042, "The key cannot be parsed as a tuple" ); | |||
There was a problem hiding this comment.
The message needs update - it says 'key'
There was a problem hiding this comment.
Good catch! Thanks!
halfprice
reviewed
Mar 25, 2022
fdbserver/storageserver.actor.cpp
Outdated
| try { | ||
| keyTuple = Tuple::unpack(keyValue->key); | ||
| } catch (Error& e) { | ||
| TraceEvent(SevError, "KeyNotTuple").detail("Key", keyValue->key.printable()); |
There was a problem hiding this comment.
Is SevError the right severity? This basically means we are in a very wrong state.
Also, do we want to log the error e here as well?
nblintao
force-pushed
the
parse-error-on-map
branch
from
fe0a06e
to
7f913f6
Compare
nblintao
changed the title
AWS CodeBuild CI Report for Linux CentOS 7
|
Doxense CI Report for Windows 10
|
halfprice
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throws specific exception instead of a more general error type.
Log the violating bytes
Make SS not retry/hang on this kind of errors
Add and fix tests
Code-Reviewer Section
The general guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormasterif this is the youngest branch)