Fixes #6793: Upgrade from 7.0.0 to 7.1.0 fails because of missing function fdb_transaction_get_mapped_range

[nblintao]

Deprecate fdb_transaction_get_range_and_flat_map which was introduced prematurely in 7.0, in preference of fdb_transaction_get_mapped_range in 7.1.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

• The PR has a description, explaining both the problem and the solution.
• The description mentions which forms of testing were done and the testing seems reasonable.
• Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

• This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
• There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

[fdb-windows-ci]

Doxense CI Report for Windows 10

• Commit ID: b373af9
• Result: ✔️ SUCCEEDED
• Build Logs (available for 30 days)

[foundationdb-ci]

AWS CodeBuild CI Report for Linux CentOS 7

• CodeBuild project: foundationdb-pr
• Commit ID: b373af9
• Result: FAILED
• Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
• Build Logs (available for 30 days)

[fdb-windows-ci]

Doxense CI Report for Windows 10

• Commit ID: da5d2a6
• Result: ✔️ SUCCEEDED
• Build Logs (available for 30 days)

[foundationdb-ci]

AWS CodeBuild CI Report for Linux CentOS 7

• CodeBuild project: foundationdb-pr
• Commit ID: da5d2a6
• Result: FAILED
• Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
• Build Logs (available for 30 days)

[fdb-windows-ci]

Doxense CI Report for Windows 10

• Commit ID: 83cdf9a
• Result: ✔️ SUCCEEDED
• Build Logs (available for 30 days)

[foundationdb-ci]

AWS CodeBuild CI Report for Linux CentOS 7

• CodeBuild project: foundationdb-pr
• Commit ID: 83cdf9a
• Result: FAILED
• Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
• Build Logs (available for 30 days)

[sfc-gh-vgasiunas]

If this function is introduced only in 7.1 you don't need to mark is as changed. Changed are functions that existed in previous versions with the same name, but their signature or behaviour have been changed.

[nblintao]

Fixed.

[sfc-gh-vgasiunas]

If we completely remove this function, this can be a problem for upgrade. Imagine an application using this function needs to be upgraded from 7.0.0 to 7.1.0. For that the application will be started with client libraries for 7.0 and 7.1 and FDB_API_VERSION=700. It won't be possible to have a version of an application that is working both with 7.0 and 7.1, because in the 7.0 library, the new function is not available and in 7.1 library the old function is not available. If you want to remove this function, you can remove it only for 7.1.0 i.e. for (#if FDB_API_VERSION >= 710). Also see how other functions were remove in the past. This means that if the 7.1. client library is used in 7.0 compatibility mode (i.e. initialized with fdb_select_api_version(700)), it must find the function providing the same signature and behavior. You have a choice between preservinv the old implementation as it was or reimplement as it as adapter of the new function. In any case, we have to be careful about this, because the CI does not test the upgrade scenarios.

[nblintao]

Discussed offline. fdb_transaction_get_range_and_flat_map was added prematurely in 7.0, but nobody actually uses and nobody needs it, so we decide to just remove it.

[sfc-gh-vgasiunas]

Also fdb_transaction_get_range_and_flat_map must be loaded, for headerVersion < 710

[nblintao]

Same. No longer support fdb_transaction_get_range_and_flat_map in 7.0.

[foundationdb-ci]

AWS CodeBuild CI Report for Linux CentOS 7

• CodeBuild project: foundationdb-pr
• Commit ID: eb270d4
• Result: SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)

[fdb-windows-ci]

Doxense CI Report for Windows 10

• Commit ID: eb270d4
• Result: ✔️ SUCCEEDED
• Build Logs (available for 30 days)