EaR: Refactor encryption header std::variant serializer and versioning #9345

sfc-gh-yiwu · 2023-02-10T04:32:45Z

Changes:

Make binary serializer natively support std::variant. Serialize size is 1 byte (the type index, i.e. std::variant::index()), plus the serialize size of the actual type stored in the std::variant. Update BlobCipherEncryptHeaderRef to use the std::variant binary serializer
Remove flagsVersion and algoHeaderVersion from BlobCipherEncryptHeaderRef. The former is replaced by flags.index() + 1, and the latter is moved into each of the algorithm-specific sub-headers. Each sub-header types will have nesting version-specific subtypes to handle serialization of that specific version (e.g. for AesCtrNoAuth it has a AesCtrNoAuthV1 subtype).

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

The PR has a description, explaining both the problem and the solution.
The description mentions which forms of testing were done and the testing seems reasonable.
Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

foundationdb-ci · 2023-02-10T04:49:42Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: a6f7d6c
Duration 0:15:26
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-02-10T04:55:46Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: a4f74dc
Duration 0:22:52
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-02-10T05:10:42Z

Result of foundationdb-pr-macos-m1 on macOS Monterey 12.x

Commit ID: a4f74dc
Duration 0:37:45
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-02-10T05:23:20Z

Result of foundationdb-pr-macos on macOS Monterey 12.x

Commit ID: a4f74dc
Duration 0:50:25
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

fdb-windows-ci · 2023-02-10T05:29:46Z

Doxense CI Report for Windows 10

Commit ID: a6f7d6c
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

foundationdb-ci · 2023-02-10T05:37:09Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: a4f74dc
Duration 1:04:14
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-02-10T05:39:01Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: a6f7d6c
Duration 1:04:43
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-02-10T05:43:06Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: a4f74dc
Duration 1:10:09
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-02-10T05:44:33Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: a6f7d6c
Duration 1:10:19
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-02-10T06:38:18Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: a6f7d6c
Duration 2:03:59
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-02-10T06:43:36Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: a4f74dc
Duration 2:10:39
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-02-10T18:34:42Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: e9b4d89
Duration 0:18:24
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

fdb-windows-ci · 2023-02-10T18:56:49Z

Doxense CI Report for Windows 10

Commit ID: e9b4d89
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

foundationdb-ci · 2023-02-10T19:02:46Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: e9b4d89
Duration 0:46:25
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-02-10T19:09:18Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: e9b4d89
Duration 0:53:01
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

sfc-gh-ahusain · 2023-02-10T19:19:18Z

fdbclient/include/fdbclient/BlobCipher.h

@@ -256,104 +261,139 @@ struct BlobCipherEncryptHeaderFlagsV1 {
 // 'encrypted buffer', compared to reading only encryptionHeader and ensuring its sanity; for instance:
 // backup-files.

-template <uint32_t AuthTokenSize>
-struct AesCtrWithAuthV1 {
+template <class Params>


Like the idea of passing class Params than adding more parameters to the template if needed in the future.

However, am not sure if following is a good idea:

Defining AesCtrWithAuth replacing version specific header, for instance: AesCtrWithAuthV1.

Pulling header and flags version from main header into component headers.

I initially had the same implementation and then moved away from it for the following reasons:

For instance, a header is defined today as follows:
struct AV1 { int a, int b, foo y; }

The usage of the code today is done as follows:
if ( struct_version == 1) { // parse and extract information from AV1 struct }

Now if the header in future gets involved (elements added and/or removed, we shall define
struct A2 {int a; int x; foo f; bar b; }

Now the usage in the code for backward compatibility will become
if (version == 1) { A1 a1 = <do necessary assignment> } else if (version == 2) { A2 a2 = <do necessary assignment> }

Compared to the proposed scheme it might end up looking like
A a; if ( version == 1) { a.<field1> = ... a.<field2> = ... } else (version == 2) { a.<field3> = ... }

I feel code #1 seems much better to read and handle (lesser accidental failures, as compiler helps catching bugs while assignment is done etc.); it may look verbose, but, then more simplistic and given header evolution might not be that common (yes we might change header, but, not super frequently I hope).

Thoughts?

We still have both ways to evolve the schema: (1) introduce a new algo type, and (2) evolve an existing algo type. If the new schema diverge substantially from any existing algo header, then we shall do (1). If the new schema share enough common parts with one of the existing header, then a pattern like

a.a = ...; if (version == 1) { a.b = ...; } else if (version == 2) { a.x = ...; a.y = ...; }

is not a bad pattern, in that it allow sharing code with clarity. Does it make sense?

in that it allow sharing code with clarity

Am not so convinced about the clarity; in some ways am worried about the if-else code clutter that needs to happen on per-field basis in extreme case. Otoh, explicit naming of struct with VersionNumber seems more clear and readable, especially given it is a on-disk structure, more explicit the code, easier for long term maintainability.

In some cases the sharing part could be non-trivial, say if the two version share most of the fields and differ in just one field, and for the other fields we want to have a lot of validation logic for them, we will not want to repeat those logics.

that said, with this patch, you can still introduce a AesCtrWithAuthV2 making it one of the algoHeader variant and rename the exiting AesCtrWithAuth to AesCtrWithAuthV1, or maybe given them a better naming than V1/V2. Say the new type can be AesCtrWithAuthAndSomeNewFeature.

In some cases the sharing part could be non-trivial, say if the two version share most of the fields and differ in just one field, and for the other fields we want to have a lot of validation logic for them, we will not want to repeat those logics.

I think we can easily abstract it out in a common header and include the fields; also, this is even used in the current design, for instance: BlobCipherDetails is used in both algorithm header.

In reality both the version are ugly, but, yes for more flexibility they are what they are. Am not sure I would say one is cleaner than other, as in near future one can easily evolve it to:
std::variant<AesCtr, AesGcm, TripleDES, RSA, BlowFish, TwoFish, RSA,....>

So even if we have one variation of the header, the list would look the same lengthy. We can easily abstract it out by using a using XXX = std::variant<xxx> if the goal is beautification.

Again, my concern here is version contained in the component headers, requires client code to be written with extra care, one mistake of not setting a required field for that particular version is a recipe for disaster. The compilation would be all fine, but, functionally it won't be. However, with explicit VersionHeader scheme, first, it makes the code more explicit while reading, one can abstract it out to define explicit functions and/or classes to handle different versions and maybe better asserts (if possible), plus, simple memory assignment would fail to compile to whatever its worth.

Btw with regard to the suggestion below:

struct AesCtrWithAuth { uint8_t version; union { AesCtrWithAuthV1 v1; AesCtrWithAuthV2 v2; } template <class Ar> void serialize(Ar& ar) { serializer(ar, version); switch (version) { case 1: serializer(ar, v1); break; case 2: serializer(ar, v2); break; } } };

Just to clarify I like the proposal above, however, all I meant is the client code still would have to do the same if-else based on the header version, but, am advocate of header evolution happening in a more explicit manner.

All up for doing it, if you like the idea as well.

If

std::variant<AesCtr, AesGcm, TripleDES, RSA, BlowFish, TwoFish, RSA,....>

is messy, then

std::variant<AesCtrV1, AesCtrV2, AesCtrV3, AesGcmV1, AesGcmV2, AesGcmV3, TripleDESV1, TripleDESV2, TripleDESV3, RSAV1, RSAV2, RSAV3, BlowFishV1, BlowFishV2, TwoFishV3, TwoFishV2, TwoFishV3, RSAV1, RSAV2, RSAV3,....>

is hell.. someone come here looking at algoHeader probably want to figure out what are the list of supported algorithms, and not for their versioning. We are deliberately mixing two layers of abstraction.

Again, my concern here is version contained in the component headers, requires client code to be written with extra care...

If you want I can make the change I proposed in #9345 (comment), adding back the V1 header, but with it nested inside the non-versioned algorithm struct, which should address your concern.

I think we just crossed messages, read my reply at #9345 (comment). I think we are on the same page here. Great discussion, thanks for doing this, Yi.

all I meant is the client code still would have to do the same if-else based on the header version

well, with that we can still enforce the "V1" client code to only deal with the V1 sub-headers and so on, achieving what you suggested, that the V1 client code don't deal with any versioning.

foundationdb-ci · 2023-02-10T19:29:07Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: c0c6eb6
Duration 0:20:26
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

fdb-windows-ci · 2023-02-10T20:19:41Z

Doxense CI Report for Windows 10

Commit ID: c0c6eb6
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

foundationdb-ci · 2023-02-10T20:23:46Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: e9b4d89
Duration 2:07:29
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-02-10T21:18:03Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: c0c6eb6
Duration 2:09:25
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-02-10T21:50:20Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 0383d25
Duration 0:19:52
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-02-10T22:33:29Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: c0c6eb6
Duration 3:24:51
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-02-10T22:48:00Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 0383d25
Duration 1:17:31
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-02-10T22:58:59Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 0383d25
Duration 1:28:29
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

sfc-gh-yiwu · 2023-02-11T01:28:42Z

CI failures are irrelevant. PR ready for review.

fdb-windows-ci · 2023-02-11T03:58:51Z

Doxense CI Report for Windows 10

Commit ID: 10fb89e
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

foundationdb-ci · 2023-02-14T02:04:46Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 1a737c7
Duration 0:17:12
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-02-14T02:30:00Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 1a737c7
Duration 0:42:24
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-02-14T02:34:15Z

Result of foundationdb-pr-macos on macOS Monterey 12.x

Commit ID: 1a737c7
Duration 0:46:41
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-02-14T02:40:07Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 1a737c7
Duration 0:52:33
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

fdb-windows-ci · 2023-02-14T02:54:25Z

Doxense CI Report for Windows 10

Commit ID: 1a737c7
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

foundationdb-ci · 2023-02-14T03:52:12Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 1a737c7
Duration 2:04:39
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

sfc-gh-ahusain

Looks great. Thanks for doing it.
Please rebase with current main , I think some recent changes might needs updates as well.

foundationdb-ci · 2023-02-14T22:34:56Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: acffa29
Duration 0:17:23
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-02-14T23:55:22Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: acffa29
Duration 1:37:51
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-02-15T00:06:57Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: acffa29
Duration 1:49:26
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-02-15T00:23:17Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: acffa29
Duration 2:05:45
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

sfc-gh-ahusain · 2023-02-15T01:03:33Z

fdbclient/BlobCipher.cpp

@@ -40,6 +40,7 @@
 #include "flow/Trace.h"
 #include "flow/UnitTest.h"
 #include "flow/xxhash.h"
+#include "include/fdbclient/BlobCipher.h"


nit: duplicate include?

will fix in separate PR.

sfc-gh-ahusain · 2023-02-15T01:07:04Z

fdbclient/include/fdbclient/BlobCipher.h

@@ -202,6 +205,15 @@ struct hash<BlobCipherDetails> {
 };
 } // namespace std

+struct EncryptHeaderCipherDetails {


am confused: this should have been already present on main?

It is just being move from line 334 to here.

sfc-gh-ahusain

Looks great. Couple of nits though.

fdb-windows-ci · 2023-02-15T03:39:56Z

Doxense CI Report for Windows 10

Commit ID: acffa29
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

sfc-gh-yiwu · 2023-02-15T04:22:02Z

I'm merging it too fast. will address final comments in separate PR.

* main: (50 commits) Client status report API in Java and python bindings (apple#9366) EaR: Update encryption methods to make 'cipherHeaderKey' optional (apple#9378) EaR: Refactor encryption header std::variant serializer and versioning (apple#9345) Fix arm nightly tests by skipping "until" restarting tests if no old binaries (apple#9362) Backup Mutation Log Separates Tenant Map Modifications During Restore (apple#9292) Remove storageEngineExcludeTypes from blob tests EaR: fix BlobCipher.h build failure Fix one more test toml spec Include missing tenants in the restore output if their state is already an error state Fix a few minor restore bugs and add a dry-run mode. Some improvements to the fdbcli output. Fix restarting to 7.2 tests for sharded rocks Save shard_encode_location_metadata knob value for restarting tests fix anyExisted when beginTenant==endTenant Enable RocksDB restarting tests Fix some merge issues and review comments Fix some merge issues Fix get mapped range test assertion to account for the possibility of a range terminating early when it reaches the end of a shard Fix merge issue Remove unnecessary try/catch Make a few minor fixes, refactor some code for clarity, and improve throughput of repopulating a management cluster ...

sfc-gh-yiwu requested review from sfc-gh-ahusain and sfc-gh-nwijetunga February 10, 2023 04:32

sfc-gh-yiwu force-pushed the encrypt_header branch from a4f74dc to a6f7d6c Compare February 10, 2023 04:34

sfc-gh-yiwu force-pushed the encrypt_header branch from a6f7d6c to e9b4d89 Compare February 10, 2023 18:16

sfc-gh-yiwu force-pushed the encrypt_header branch from e9b4d89 to c0c6eb6 Compare February 10, 2023 19:08

sfc-gh-ahusain reviewed Feb 10, 2023

View reviewed changes

sfc-gh-yiwu force-pushed the encrypt_header branch from c0c6eb6 to 0383d25 Compare February 10, 2023 21:30

sfc-gh-yiwu changed the title ~~EaR: Refactor encryption header with std::variant binary serializer support~~ EaR: Refactor encryption header std::variant serializer and versioning Feb 11, 2023

sfc-gh-yiwu marked this pull request as draft February 13, 2023 23:47

add back the v1 types

1a737c7

sfc-gh-ahusain previously approved these changes Feb 14, 2023

View reviewed changes

sfc-gh-yiwu added 2 commits February 14, 2023 13:37

fix blob file validateEncryptionHeaderDetails

35bce28

Merge branch 'main' into encrypt_header

acffa29

sfc-gh-yiwu dismissed sfc-gh-ahusain’s stale review via acffa29 February 14, 2023 22:17

sfc-gh-yiwu marked this pull request as ready for review February 15, 2023 00:11

sfc-gh-ahusain self-requested a review February 15, 2023 00:23

sfc-gh-ahusain reviewed Feb 15, 2023

View reviewed changes

sfc-gh-ahusain approved these changes Feb 15, 2023

View reviewed changes

sfc-gh-yiwu merged commit 3d882a9 into apple:main Feb 15, 2023

sfc-gh-yiwu deleted the encrypt_header branch February 15, 2023 04:19

sfc-gh-yiwu mentioned this pull request Feb 15, 2023

EaR: cleanup encryption knobs #9386

Merged

5 tasks

EaR: Refactor encryption header std::variant serializer and versioning #9345

EaR: Refactor encryption header std::variant serializer and versioning #9345

Conversation

sfc-gh-yiwu commented Feb 10, 2023 • edited Loading

Code-Reviewer Section

For Release-Branches

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr-macos-m1 on macOS Monterey 12.x

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr-macos on macOS Monterey 12.x

fdb-windows-ci commented Feb 10, 2023

Doxense CI Report for Windows 10

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

fdb-windows-ci commented Feb 10, 2023

Doxense CI Report for Windows 10

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

Choose a reason for hiding this comment

sfc-gh-yiwu Feb 10, 2023 • edited Loading

Choose a reason for hiding this comment

sfc-gh-ahusain Feb 10, 2023 • edited Loading

Choose a reason for hiding this comment

sfc-gh-yiwu Feb 10, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sfc-gh-ahusain Feb 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sfc-gh-yiwu Feb 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sfc-gh-yiwu Feb 11, 2023 • edited Loading

Choose a reason for hiding this comment

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

fdb-windows-ci commented Feb 10, 2023

Doxense CI Report for Windows 10

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented Feb 10, 2023

Result of foundationdb-pr on Linux CentOS 7

sfc-gh-yiwu commented Feb 11, 2023

fdb-windows-ci commented Feb 11, 2023

Doxense CI Report for Windows 10

foundationdb-ci commented Feb 14, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

foundationdb-ci commented Feb 14, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented Feb 14, 2023

Result of foundationdb-pr-macos on macOS Monterey 12.x

foundationdb-ci commented Feb 14, 2023

Result of foundationdb-pr on Linux CentOS 7

fdb-windows-ci commented Feb 14, 2023

sfc-gh-yiwu commented Feb 10, 2023 •

edited

Loading

sfc-gh-yiwu Feb 10, 2023 •

edited

Loading

sfc-gh-ahusain Feb 10, 2023 •

edited

Loading

sfc-gh-yiwu Feb 10, 2023 •

edited

Loading

sfc-gh-ahusain Feb 11, 2023 •

edited

Loading

sfc-gh-yiwu Feb 11, 2023 •

edited

Loading

sfc-gh-yiwu Feb 11, 2023 •

edited

Loading