Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert org.pkl.executor.Version.Identifier POJO to record class #836

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KushalP
Copy link
Contributor

@KushalP KushalP commented Dec 2, 2024

No description provided.

@KushalP KushalP force-pushed the org.pkl.executor-record branch from 998b22e to 6d95fdc Compare December 12, 2024 15:49
@KushalP KushalP changed the title Convert org.pkl.executor POJOs to record classes Convert org.pkl.executor.Version.Identifier POJO to record class Dec 12, 2024
@KushalP KushalP requested a review from odenix December 12, 2024 15:49
@KushalP KushalP force-pushed the org.pkl.executor-record branch 2 times, most recently from 2508cf9 to 3797366 Compare December 12, 2024 15:51
@KushalP
Copy link
Contributor Author

KushalP commented Dec 12, 2024

Removed the change to the class that was called out by @odenix.

Copy link
Contributor

@bioball bioball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants