Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support test script #40

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Add support test script #40

merged 1 commit into from
Sep 14, 2021

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Sep 9, 2021

This semi-automated test script exercises some build configurations that aren't covered by regular CI runs.

This includes:

  • Building and testing with various swiftpm setups:
    • debug vs release,
    • with and without doublewide atomics,
    • with and without library evolution turned on (this is unsupported but why break it),
    • warnings-as-errors on & off
  • Building & testing with xcodebuild
    • macOS
    • Mac Catalyst
    • iOS
    • watchOS
    • tvOS
  • Building & testing with CMake
    • debug vs release

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've verified that my change does not break any existing tests.
  • I've updated the documentation if necessary.

@lorentey lorentey requested a review from glessard September 9, 2021 01:16
@lorentey
Copy link
Member Author

lorentey commented Sep 9, 2021

@swift-ci test

@lorentey
Copy link
Member Author

lorentey commented Sep 9, 2021

An issue @glessard noticed is that the spm.debug tests are taking a huge amount of time on AS machines. This is worth investigating, as it seems to indicate some ARM-specific codegen issue. Double wide atomics are inordinately slow (or even broken) in debug builds.

Copy link
Contributor

@glessard glessard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We found issues in debug-mode tests on M1, but those are not caused by this fine script.

@lorentey
Copy link
Member Author

We'll use #41 to track the arm64 issue; this looks good to merge.

This semi-automated test script exercises some build configurations that aren't covered by regular CI runs.
@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey merged commit 2eb6b8d into apple:main Sep 14, 2021
@lorentey lorentey added this to the 1.0.2 milestone Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants