Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we can rely on https://reviews.llvm.org/D86218, we don’t need to tiptoe around the use of
_Atomic(struct _sa_dword)
.Rip out the clumsy encode/decode mess and the use of
__uint128_t
.As a side effect of removing the use of
__uint128_t
, this PR deprecates theDoubleWord.low
andDoubleWord.high
properties (and the associated initializer), replacing them withfirst
andsecond
.Checklist