Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify shims #70

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Simplify shims #70

merged 2 commits into from
Mar 20, 2023

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Mar 18, 2023

Now that we can rely on https://reviews.llvm.org/D86218, we don’t need to tiptoe around the use of _Atomic(struct _sa_dword).

Rip out the clumsy encode/decode mess and the use of __uint128_t.

As a side effect of removing the use of __uint128_t, this PR deprecates the DoubleWord.low and DoubleWord.high properties (and the associated initializer), replacing them with first and second.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've verified that my change does not break any existing tests.
  • I've updated the documentation if necessary.

@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey added this to the 1.1.0 milestone Mar 18, 2023
@lorentey
Copy link
Member Author

@swift-ci test

Now that we can rely on https://reviews.llvm.org/D86218, we don’t need to tiptoe around the use of `_Atomic(struct dword)`.

Rip out the clumsy encode/decode mess and the use of __uint128_t.
@lorentey
Copy link
Member Author

@swift-ci test

@lorentey
Copy link
Member Author

@swift-ci test

@stephentyrone
Copy link
Member

deprecating high/low fills me with joy.

@lorentey lorentey merged commit 57e4436 into apple:main Mar 20, 2023
@lorentey lorentey deleted the simplify-shims branch March 20, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants