Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.1 release preparations #82

Merged
merged 3 commits into from
Mar 31, 2023
Merged

1.1 release preparations #82

merged 3 commits into from
Mar 31, 2023

Conversation

lorentey
Copy link
Member

This fixes a subtle issue with ManagedAtomic/ManagedAtomicLazyReference deinitialization (discovered during release testing), and does some prerelease cleanups in the CMake and Xcode project configurations.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've verified that my change does not break any existing tests.
  • I've updated the documentation if necessary.

lorentey added 3 commits March 31, 2023 15:19
@lorentey
ManagedAtomic[LazyReference]: Always access ivar through pointer
bbee754 
The deinit implementations used to access the ivar directly, but that can confuse the compiler into assuming the value never changes after its initialization, because it doesn’t see accesses that are done via the pointer.

Stop accessing the ivar directly once it has been initialized.
@lorentey
Update CMake test configuration
5aad046
@lorentey
Update Xcode project
581634c
@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey merged commit 6287624 into apple:main Mar 31, 2023
@lorentey lorentey deleted the finalize-1.1 branch March 31, 2023 22:26
@lorentey lorentey added this to the 1.1.0 milestone Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@lorentey