[_AtomicShims] On Darwin, ensure we link against libswiftCore using assembly shenanigans #97
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssembly shenanigans This avoids a linker failure when the build system decides to build this module as a standalone library. Hopefully this will all go away soon, when swift_retain_n/swift_release_n will become primitives exposed by the stdlib.
2 tasks
|
@swift-ci test |
|
Local testing confirms that this resolves the issue that's plaguing #55 (and rdar://108390931). |
Not so fast! It looks like the method I'm using to override the swift-atomics release tag with a local checkout also resolves it, by itself. Grr. |
lorentey
commented
Aug 14, 2023
| // Ensure we link with libswiftCore.dylib even when the build system decides | ||
| // to build this module as a standalone library. | ||
| // (See https://github.com/apple/swift-atomics/issues/55) | ||
| __asm__(".linker_option \"-L/usr/lib/swift\"\n"); |
There was a problem hiding this comment.
Ah, -L doesn't actually work, but (for some reason) it also seems unnecessary, at least on 5.9.
This emits a warning and it seems to be unnecessary.
|
@swift-ci test |
This was referenced Aug 14, 2023
glessard
approved these changes
Aug 14, 2023
|
@lorentey does Swift 5.9 expose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #95 and #96, the intention here is to avoid a linker failure when the build system decides to build this module as a standalone library.
Hopefully this will all go away soon, when swift_retain_n/swift_release_n will become primitives exposed by the stdlib.
Resolves #55
Checklist