-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change NIOTSNetworkEvent initializers visibility to public level #148
Conversation
Can one of the admins verify this patch? |
5 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swift-server-bot test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, LGTM.
@swift-nio-bot test this please |
[One line description of your change]
Change NIOTSNetworkEvent initializers visibility to public level.
Motivation:
[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]
Solves issue #147. Public initializers allow to extend unit test of async-http-client. For more details, see async-http-client #589
Modifications:
[Describe the modifications you've done.]
Add public initializers for all NIOTSNetworkEvents.
Result:
[After your change, what will change.]
NIOTSNetworkEvent initializers will be available across different packages.