Launching Services with existing NWConnection or NWListener objects #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NIO Transport Services is not capable of launching services with existing NWConnection or NWListener objects. Being able to get an existing NWConnection through a connection bootstrap and into a channel is a useful capability for advanced use cases. Modifications: * Added an option to bootstrap with existing NWListener and NWConnection * Completed promise connection earlier within NIOTSChannels when AlreadyConfigured is called * Added test with new NWConnection and NWListener to register Channels Result: Able to create and register a channel using an existing NWListener and NWConnection
|
Can one of the admins verify this patch? |
5 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@swift-server-bot add to allowlist |
Lukasa
requested changes
Sep 20, 2022
| @@ -205,7 +219,11 @@ public final class NIOTSConnectionBootstrap { | |||
| initializer(conn) | |||
| }.flatMap { | |||
| conn.eventLoop.assertInEventLoop() | |||
| return conn.register() | |||
| if shouldRegister{ | |||
There was a problem hiding this comment.
Suggested change
| if shouldRegister{ | |
| if shouldRegister { |
| tcpOptions: tcpOptions, | ||
| tlsOptions: tlsOptions, | ||
| childLoopGroup: childLoopGroup, | ||
| childChannelQoS:childChannelQoS, |
There was a problem hiding this comment.
Suggested change
| childChannelQoS:childChannelQoS, | |
| childChannelQoS: childChannelQoS, |
| tlsOptions: tlsOptions, | ||
| childLoopGroup: childLoopGroup, | ||
| childChannelQoS:childChannelQoS, | ||
| childTCPOptions:childTCPOptions, |
There was a problem hiding this comment.
Suggested change
| childTCPOptions:childTCPOptions, | |
| childTCPOptions: childTCPOptions, |
| childLoopGroup: childLoopGroup, | ||
| childChannelQoS:childChannelQoS, | ||
| childTCPOptions:childTCPOptions, | ||
| childTLSOptions:childTLSOptions |
There was a problem hiding this comment.
Suggested change
| childTLSOptions:childTLSOptions | |
| childTLSOptions: childTLSOptions |
| let buffer = connection.allocator.bufferFor(string: "hello, world!") | ||
| let completeFuture = connection.expectRead(buffer) | ||
| connection.writeAndFlush(buffer, promise: nil) | ||
| // this is the assert that matters to make sure it works writes data |
There was a problem hiding this comment.
Suggested change
| // this is the assert that matters to make sure it works writes data | |
| // this is the assert that matters to make sure it works & writes data |
| @@ -526,7 +555,7 @@ class NIOTSEndToEndTests: XCTestCase { | |||
| .connect(to: address) | |||
| .wait()) { error in | |||
| print(error) | |||
| } | |||
| } | |||
Lukasa
reviewed
Sep 21, 2022
| /// Use a pre-existing `NWConnection` to connect a `Channel`. | ||
| /// | ||
| /// - parameters: | ||
| /// - connection: The NWConnection path to wrap. |
There was a problem hiding this comment.
Suggested change
| /// - connection: The NWConnection path to wrap. | |
| /// - connection: The NWConnection to wrap. |
| /// Bind the `NIOTSListenerChannel` to an existing `NWListener`. | ||
| /// | ||
| /// - parameters: | ||
| /// - listener: The NWListener path to bind. |
There was a problem hiding this comment.
Suggested change
| /// - listener: The NWListener path to bind. | |
| /// - listener: The NWListener to wrap. |
| @@ -128,6 +128,28 @@ internal final class NIOTSListenerChannel { | |||
| // Must come last, as it requires self to be completely initialized. | |||
| self._pipeline = ChannelPipeline(channel: self) | |||
| } | |||
|
|
|||
| /// Create a `NIOTSConnectionChannel` with an already-established `NWListener`. | |||
There was a problem hiding this comment.
Suggested change
| /// Create a `NIOTSConnectionChannel` with an already-established `NWListener`. | |
| /// Create a `NIOTSListenerChannel` with an already-established `NWListener`. |
Lukasa
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NIO Transport Services is not capable of launching services with existing NWConnection or NWListener objects. Being able to get an existing NWConnection through a connection bootstrap and into a channel is a useful capability for advanced use cases.
Modifications:
Result:
Able to create and register a channel using an existing NWListener and NWConnection