Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing availability annotation to NIOTSConnectionBootstrap #160

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

glbrntt
Copy link
Contributor

@glbrntt glbrntt commented Sep 28, 2022

Motivation:

  • NIOTSConnectionBootstrap was extended to be marked as non-Sendable, this extenion missed the availability annotations.

Modifications:

  • Add appropriate availability annotation

Result:

Resolves #159

Motivation:

- NIOTSConnectionBootstrap was extended to be marked as non-Sendable,
  this extenion missed the availability annotations.

Modifications:

- Add appropriate availability annotation

Result:

Resolves apple#159
@glbrntt glbrntt added the semver/patch No public API change. label Sep 28, 2022
@glbrntt glbrntt requested a review from Lukasa September 28, 2022 14:46
@Skoti
Copy link

Skoti commented Sep 28, 2022

I think NIOFilterEmptyWritesHandler also needs to be fixed:

#if swift(>=5.6)
@available(*, unavailable)
extension NIOFilterEmptyWritesHandler: Sendable {}
#endif
// Connection state management
extension NIOFilterEmptyWritesHandler {

@Lukasa Lukasa merged commit b6e37a0 into apple:main Sep 28, 2022
@glbrntt
Copy link
Contributor Author

glbrntt commented Sep 28, 2022

I think NIOFilterEmptyWritesHandler also needs to be fixed:

#if swift(>=5.6)
@available(*, unavailable)
extension NIOFilterEmptyWritesHandler: Sendable {}
#endif
// Connection state management
extension NIOFilterEmptyWritesHandler {

NIOFilterEmptyWritesHandler doesn't have availability requirements:

public final class NIOFilterEmptyWritesHandler: ChannelDuplexHandler {

@glbrntt glbrntt deleted the gb-add-missing-annotation branch September 28, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URGENT : NIOTransportServices / NIOTSConnectionBootstrap is only available in macOS 10.14 or newer
3 participants