Remove #if compiler(>=5.5)
#161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnadoba
commented
Oct 13, 2022
Comment on lines
-106
to
108
| #if swift(>=5.6) | ||
| @available(OSX 10.14, iOS 12.0, tvOS 12.0, watchOS 6.0, *) | ||
| extension NIOTSNetworkEvents.BetterPathAvailable: Sendable {} | ||
| @available(OSX 10.14, iOS 12.0, tvOS 12.0, watchOS 6.0, *) |
There was a problem hiding this comment.
This says 5.6 but I think it should have been 5.5. Lets see if CI complains.
dnadoba
force-pushed
the
dn-remove-swift-5.4-support
branch
from
4c7c6d8
to
b5c31d0
Compare
Lukasa
approved these changes
Oct 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We only support Swift 5.5.2+.
Modification
Remove all
#if swift(>=5.5)conditional compilation blocks.Result
less branching