Use underscore version of NIOPreconcurrencySendable to silence warning
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation `swift-nio` has deprecated `NIOPreconcurrencySendable` in `2.51.0`. Removing the protocol conformance would be an API breaking change. Keeping the conformance is low cost and not worth the risk. ### Changes - replace `NIOPreconcurrencySendable` with underscore version `_NIOPreconcurrencySendable` ### Result We compile again with the latest `swift-nio` release without warnings
glbrntt
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
swift-niohas deprecatedNIOPreconcurrencySendablein2.51.0. Removing the protocol conformance would be an API breaking change. Keeping the conformance is low cost and not worth the risk.Modifications
NIOPreconcurrencySendablewith underscore version_NIOPreconcurrencySendableResult
We compile again with the latest
swift-niorelease without warnings