Fire the pipelines error caught method when NWConnection's state changes to failed #187
Conversation
… for forwarding failed connnection state errors
|
Done ✅, Hopefully the test is sufficient. Thanks a bunch! |
|
@Lukasa I am happy to do what I can to push this one through. Thanks for your work. |
| let channelError = error as? ChannelError | ||
| if channelError != .eof { | ||
| self.pipeline.fireErrorCaught(error) | ||
| } |
There was a problem hiding this comment.
Can you clean up the indentation here please?
| // Step 2 is to fail all outstanding writes. | ||
| self.dropOutstandingWrites(error: error) | ||
|
|
||
There was a problem hiding this comment.
Can you remove the added whitespace here?
There was a problem hiding this comment.
It appears that on the main branch lines 262, 266, and 269 all have a single whitespace for those lines. Did I misunderstand what was needed?
| .childChannelInitializer { channel in | ||
| return channel.eventLoop.makeSucceededVoidFuture() | ||
| } | ||
| .bind(host: "127.0.0.1", port: 8080) |
There was a problem hiding this comment.
Can we bind 0 instead? This can cause awkward conflicts if this port is in use somewhere else.
| context.channel.write(ByteBuffer(data: Data())) | ||
| .whenFailure({ error in | ||
| listenerErrorPromise.succeed(error) | ||
| }) |
There was a problem hiding this comment.
I don't think this path should complete the promise: we're testing for this happening in errorcaught, not on the write promise.
There was a problem hiding this comment.
Are you cool with me just throwing the result of the write away?
|
Can you bring your branch up-to-date with main? |
|
@Lukasa ✅ |
|
@swift-server-bot test this please |
Fire the pipelines error caught method when NWConnection's state changes to failed
There seems to need to be a method fired when NSConnection's state changes to failed in order to notify other handlers in the pipeline.
Motivation:
When NWConnection fails the connection due to a number of reasons, one being that the clients devices loses internet and we want to receive the failed error in order to handle the applications behavior when the internet is lost. We need to fire the
errorCaughtmethod in order to notify handler's in the pipeline.Modifications:
On line 277 of the file StateManagedNWConnectionChannel.swift I added the line of code to forward the error, namely...
self.pipeline.fireErrorCaught(error)Result:
Our Handlers can now receive the error and handle the socket error state accordingly.