Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChannelOptions to extract base types. #203

Merged
merged 1 commit into from
May 13, 2024

Conversation

Lukasa
Copy link
Collaborator

@Lukasa Lukasa commented May 13, 2024

Motivation:

In some cases users may want to access APIs we haven't exposed in NIOTransportServices. We should have a fallback that allows users to do this.

Modifications:

  • Add ChannelOptions for getting NWConnection and NWListener.

Result:

Users have an escape hatch

@Lukasa Lukasa added the semver/minor Adds new public API. label May 13, 2024
Motivation:

In some cases users may want to access APIs we haven't exposed
in NIOTransportServices. We should have a fallback that allows users
to do this.

Modifications:

- Add ChannelOptions for getting NWConnection and NWListener.

Result:

Users have an escape hatch
@Lukasa Lukasa force-pushed the cb-channel-options-to-get-base-types branch from 5a4d29a to 96d0211 Compare May 13, 2024 16:43
Copy link
Member

@FranzBusch FranzBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Lukasa Lukasa merged commit 38ac822 into apple:main May 13, 2024
6 checks passed
@Lukasa Lukasa deleted the cb-channel-options-to-get-base-types branch May 13, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants