Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle .url endpoint in switches over endpoint. #48

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

Lukasa
Copy link
Collaborator

@Lukasa Lukasa commented Jun 18, 2019

Motivation:

macOS Catalina brings a .url endpoint to Network.framework, which is
currently causing build warnings. We should tolerate it and silence
those warnings.

Modifications:

Do the right thing when we receive a .url endpoint.

Result:

No build warnings.

@Lukasa Lukasa added the semver/patch No public API change. label Jun 18, 2019
@Lukasa Lukasa added this to the 1.1.0 milestone Jun 18, 2019
@Lukasa Lukasa requested a review from weissi June 18, 2019 13:27
Motivation:

macOS Catalina brings a .url endpoint to Network.framework, which is
currently causing build warnings. We should tolerate it and silence
those warnings.

Modifications:

Do the right thing when we receive a .url endpoint.

Result:

No build warnings.
Copy link
Member

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ,thanks

@weissi weissi merged commit afbbead into apple:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants