Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower EventLoopGroup requirements for creating bootstraps #49

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Lower EventLoopGroup requirements for creating bootstraps #49

merged 2 commits into from
Jul 3, 2019

Commits on Jul 3, 2019

  1. Lower EventLoopGroup requirements for creating bootstraps 

    Motivation:

In NIO `ClientBootstrap` and `ServerBootstrap` are initialized with an
`EventLoopGroup`. Since `EventLoop` conforms to `EventLoopGroup` you can
initialize an bootstrap with an existing event loop. In NIO Transport
Services the bootstraps are initialized with a `NIOTSEventLoopGroup` and
as `NIOTSEventLoop` conforms to `EventLoop` and by extension
`EventLoopGroup` (but not `NIOTSEventLoopGroup`) it is not possible to
initialize a bootstrap with a pre-existing `NIOTSEventLoop`.

Modifications:

Change the bootstrap initializers to accept an `EventLoopGroup`.

Result:

NIO Transport Services bootstraps can be initialized with a
`NIOTSEventLoop`.
    @glbrntt
    glbrntt committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    80edee8 View commit details
    Browse the repository at this point in the history

  2. Un-break API changes

    @glbrntt
    glbrntt committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    24a2d50 View commit details
    Browse the repository at this point in the history